Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename MasterKey by ApiKey #162

Merged
merged 1 commit into from
Jun 29, 2021
Merged

Rename MasterKey by ApiKey #162

merged 1 commit into from
Jun 29, 2021

Conversation

alallema
Copy link
Contributor

@alallema alallema commented Jun 29, 2021 •
edited by curquiza
Loading

close #160

Not breaking because a roll back in the same release

@alallema alallema requested a review from curquiza June 29, 2021 09:30
curquiza
curquiza approved these changes Jun 29, 2021
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @alallema!

@alallema
Copy link
Contributor Author

bors merge

@bors
Copy link
Contributor

bors bot commented Jun 29, 2021

Build succeeded:

@bors bors bot merged commit d5df1aa into main Jun 29, 2021
@bors bors bot deleted the fix-bad-naming branch June 29, 2021 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curquiza curquiza curquiza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bad naming MasterKey
2 participants
@alallema @curquiza