Merge pull request #255 from meilisearch/get-or-create

Remove `GetOrCreateIndex` method
meilisearch · Jan 24, 2022 · 67d29de · 67d29de
2 parents 95dda12 + c1fdb5e
commit 67d29de
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 76 deletions.
diff --git a/client.go b/client.go
@@ -29,7 +29,6 @@ type ClientInterface interface {
 	GetAllIndexes() (resp []*Index, err error)
 	GetAllRawIndexes() (resp []map[string]interface{}, err error)
 	CreateIndex(config *IndexConfig) (resp *Index, err error)
-	GetOrCreateIndex(config *IndexConfig) (resp *Index, err error)
 	DeleteIndex(uid string) (bool, error)
 	DeleteIndexIfExists(uid string) (bool, error)
 	GetKeys() (resp *Keys, err error)

diff --git a/client_index.go b/client_index.go
@@ -79,14 +79,6 @@ func (c *Client) GetAllRawIndexes() (resp []map[string]interface{}, err error) {
 	return resp, nil
 }
 
-func (c *Client) GetOrCreateIndex(config *IndexConfig) (resp *Index, err error) {
-	resp, err = c.GetIndex(config.Uid)
-	if err == nil {
-		return resp, err
-	}
-	return c.CreateIndex(config)
-}
-
 func (c *Client) DeleteIndex(uid string) (ok bool, err error) {
 	req := internalRequest{
 		endpoint:            "/indexes/" + uid,

diff --git a/client_index_test.go b/client_index_test.go
@@ -766,73 +766,6 @@ func TestClient_GetRawIndex(t *testing.T) {
 	}
 }
 
-func TestClient_GetOrCreateIndex(t *testing.T) {
-	type args struct {
-		config IndexConfig
-	}
-	tests := []struct {
-		name     string
-		client   *Client
-		args     args
-		wantResp *Index
-	}{
-		{
-			name:   "TestBasicGetOrCreateIndex",
-			client: defaultClient,
-			args: args{
-				config: IndexConfig{
-					Uid: "TestBasicGetOrCreateIndex",
-				},
-			},
-			wantResp: &Index{
-				UID: "TestBasicGetOrCreateIndex",
-			},
-		},
-		{
-			name:   "TestGetOrCreateIndexWithCustomClient",
-			client: customClient,
-			args: args{
-				config: IndexConfig{
-					Uid: "TestBasicGetOrCreateIndex",
-				},
-			},
-			wantResp: &Index{
-				UID: "TestBasicGetOrCreateIndex",
-			},
-		},
-		{
-			name:   "TestGetOrCreateIndexWithPrimaryKey",
-			client: defaultClient,
-			args: args{
-				config: IndexConfig{
-					Uid:        "TestGetOrCreateIndexWithPrimaryKey",
-					PrimaryKey: "PrimaryKey",
-				},
-			},
-			wantResp: &Index{
-				UID:        "TestGetOrCreateIndexWithPrimaryKey",
-				PrimaryKey: "PrimaryKey",
-			},
-		},
-	}
-	for _, tt := range tests {
-		t.Run(tt.name, func(t *testing.T) {
-			c := tt.client
-			t.Cleanup(cleanup(c))
-
-			gotResp, err := c.GetOrCreateIndex(&tt.args.config)
-			require.NoError(t, err)
-			if assert.NotNil(t, gotResp) {
-				require.Equal(t, tt.wantResp.UID, gotResp.UID)
-				require.Equal(t, tt.wantResp.PrimaryKey, gotResp.PrimaryKey)
-				// Make sure that timestamps are also retrieved
-				require.NotZero(t, gotResp.CreatedAt)
-				require.NotZero(t, gotResp.UpdatedAt)
-			}
-		})
-	}
-}
-
 func TestClient_Index(t *testing.T) {
 	type args struct {
 		uid string