feat(settings): Add sortFacetValuesBy #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brunoocasali looks like uploading to codecov failed for some reason, can you look into it ? Update: looks like it's flakey, maybe due to rate limiting for not providing API key ? |
brunoocasali
approved these changes
Sep 1, 2023
|
Build succeeded:
|
brunoocasali
added
the
breaking-change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Fixes #339
What does this PR do?
enum FacetingSortTypesMap<String, FacetingSortTypes>? sortFacetValuesBytoFaceting.code-samples.meilisearch.yamlFacetingto be final, and remove the default values set there.PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!