Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure the CSV delimiter when updating documents #292

Closed
2 tasks
brunoocasali opened this issue Apr 27, 2023 · 0 comments · Fixed by #295
Closed
2 tasks

Configure the CSV delimiter when updating documents #292

brunoocasali opened this issue Apr 27, 2023 · 0 comments · Fixed by #295
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@brunoocasali
Copy link
Member

⚠️ This issue is generated, it means the examples and the namings do not necessarily correspond to the language of this repository.
Also, if you are a maintainer, feel free to add any clarification and instruction about this issue.

Sorry if this is already partially/completely implemented, feel free to let me know about the state of this issue in the repo.

Related to meilisearch/integration-guides#251

Related to:

Add support for passing csvDelimiter query parameter to the PUT and POST /indexes/:indexUid/documents with content-type text/csv (example of the real method names: updateDocuments, addDocuments).

Also, a new error code is introduced, invalid_document_csv_delimiter. Pay attention to the strongly typed languages.

TODO:

  • Add the new argument to the csv document handler methods.
  • Add tests
@brunoocasali brunoocasali added enhancement New feature or request good first issue Good for newcomers labels Apr 27, 2023
@ahmednfwela ahmednfwela mentioned this issue Apr 27, 2023
Merged
3 tasks
bors bot added a commit that referenced this issue Apr 28, 2023
@bors @ahmednfwela
Merge #295
3505e83 
295: Support for custom csv delimiter r=brunoocasali a=ahmednfwela

# Pull Request

## Related issue
Fixes #292

## What does this PR do?
- Adds csvDelimiter parameter to `addDocumentsCsv`, `addDocumentsCsvInBatches`, `updateDocumentsCsv`, `updateDocumentsCsvInBatches`
- Adds tests

## PR checklist
Please check if your PR fulfills the following requirements:
- [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

cc `@brunoocasali` 

Co-authored-by: Ahmed Fwela <ahmednfwela@bdaya-dev.com>
@bors bors bot closed this as completed in 04dcd2e Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support for custom csv delimiter Bdaya-Dev/meilisearch-dart
1 participant
@brunoocasali