-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes related to MeiliSearch v0.23.0 #142
Comments
This was referenced Sep 29, 2021
bors bot
added a commit
to meilisearch/meilisearch-ruby
that referenced
this issue
Oct 12, 2021
219: Changes related to the next MeiliSearch release (v0.23.0) r=curquiza a=meili-bot Related to this issue: meilisearch/integration-guides#142 This PR: - gathers the changes related to the next MeiliSearch release (v0.23.0) so that this package is ready when the official release is out. - should pass the tests against the [latest pre-release of MeiliSearch](https://github.com/meilisearch/MeiliSearch/releases). - might eventually contain test failures until the MeiliSearch v0.23.0 is out.⚠️ This PR should NOT be merged until the next release of MeiliSearch (v0.23.0) is out. _This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/master/guides/pre-release-week.md) purpose._ Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com> Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com>
bors bot
added a commit
to meilisearch/meilisearch-dart
that referenced
this issue
Oct 12, 2021
87: Changes related to the next MeiliSearch release (v0.23.0) r=curquiza a=meili-bot Related to this issue: meilisearch/integration-guides#142 This PR: - gathers the changes related to the next MeiliSearch release (v0.23.0) so that this package is ready when the official release is out. - should pass the tests against the [latest pre-release of MeiliSearch](https://github.com/meilisearch/MeiliSearch/releases). - might eventually contain test failures until the MeiliSearch v0.23.0 is out.⚠️ This PR should NOT be merged until the next release of MeiliSearch (v0.23.0) is out. _This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/master/guides/pre-release-week.md) purpose._ Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com> Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com>
bors bot
added a commit
to meilisearch/meilisearch-rust
that referenced
this issue
Oct 12, 2021
177: Changes related to the next MeiliSearch release (v0.23.0) r=curquiza a=meili-bot Related to this issue: meilisearch/integration-guides#142 This PR: - gathers the changes related to the next MeiliSearch release (v0.23.0) so that this package is ready when the official release is out. - should pass the tests against the [latest pre-release of MeiliSearch](https://github.com/meilisearch/MeiliSearch/releases). - might eventually contain test failures until the MeiliSearch v0.23.0 is out.⚠️ This PR should NOT be merged until the next release of MeiliSearch (v0.23.0) is out. _This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/master/guides/pre-release-week.md) purpose._ Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com> Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com>
bors bot
added a commit
to meilisearch/meilisearch-js
that referenced
this issue
Oct 12, 2021
1013: Changes related to the next MeiliSearch release (v0.23.0) r=bidoubiwa a=meili-bot Related to this issue: meilisearch/integration-guides#142 This PR: - gathers the changes related to the next MeiliSearch release (v0.23.0) so that this package is ready when the official release is out. - should pass the tests against the [latest pre-release of MeiliSearch](https://github.com/meilisearch/MeiliSearch/releases). - might eventually contain test failures until the MeiliSearch v0.23.0 is out.⚠️ This PR should NOT be merged until the next release of MeiliSearch (v0.23.0) is out. _This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/master/guides/pre-release-week.md) purpose._ Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com> Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com>
bors bot
added a commit
to meilisearch/meilisearch-python
that referenced
this issue
Oct 12, 2021
327: Changes related to the next MeiliSearch release (v0.23.0) r=alallema a=meili-bot Related to this issue: meilisearch/integration-guides#142 This PR: - gathers the changes related to the next MeiliSearch release (v0.23.0) so that this package is ready when the official release is out. - should pass the tests against the [latest pre-release of MeiliSearch](https://github.com/meilisearch/MeiliSearch/releases). - might eventually contain test failures until the MeiliSearch v0.23.0 is out.⚠️ This PR should NOT be merged until the next release of MeiliSearch (v0.23.0) is out. _This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/master/guides/pre-release-week.md) purpose._ Done: - #329 - Add new methods: - `addDocumentsJson(string $documents, ?string $primaryKey = null)` - `addDocumentsNdJson(string $documents, ?string $primaryKey = null)` - `addDocumentsCsv(string $documents, ?string $primaryKey = null)` - Add tests for new methods - Remove json header `application/json` for every http methods - #331 Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com> Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com> Co-authored-by: alallema <amelie@meilisearch.com> Co-authored-by: Amélie <alallema@users.noreply.github.com>
bors bot
added a commit
to meilisearch/meilisearch-go
that referenced
this issue
Oct 12, 2021
195: Changes related to the next MeiliSearch release (v0.23.0) r=alallema a=meili-bot Related to this issue: meilisearch/integration-guides#142 This PR: - gathers the changes related to the next MeiliSearch release (v0.23.0) so that this package is ready when the official release is out. - should pass the tests against the [latest pre-release of MeiliSearch](https://github.com/meilisearch/MeiliSearch/releases). - might eventually contain test failures until the MeiliSearch v0.23.0 is out.⚠️ This PR should NOT be merged until the next release of MeiliSearch (v0.23.0) is out. _This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/master/guides/pre-release-week.md) purpose._ Done: - #211 Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com> Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com> Co-authored-by: Amélie <alallema@users.noreply.github.com> Co-authored-by: alallema <amelie@meilisearch.com>
bors bot
added a commit
to meilisearch/meilisearch-php
that referenced
this issue
Oct 12, 2021
214: Changes related to the next MeiliSearch release (v0.23.0) r=alallema a=meili-bot Related to this issue: meilisearch/integration-guides#142 This PR: - gathers the changes related to the next MeiliSearch release (v0.23.0) so that this package is ready when the official release is out. - should pass the tests against the [latest pre-release of MeiliSearch](https://github.com/meilisearch/MeiliSearch/releases). - might eventually contain test failures until the MeiliSearch v0.23.0 is out.⚠️ This PR should NOT be merged until the next release of MeiliSearch (v0.23.0) is out. _This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/master/guides/pre-release-week.md) purpose._ Done: - #230 - #235 - Add new methods: - `addDocumentsJson(string $documents, ?string $primaryKey = null)` - `addDocumentsNdJson(string $documents, ?string $primaryKey = null)` - `addDocumentsCsv(string $documents, ?string $primaryKey = null)` - Add tests for new methods + files - Remove json header `application/json` for every http methods Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com> Co-authored-by: Amélie <alallema@users.noreply.github.com> Co-authored-by: alallema <amelie@meilisearch.com>
bors bot
added a commit
to meilisearch/meilisearch-swift
that referenced
this issue
Oct 12, 2021
202: Changes related to the next MeiliSearch release (v0.23.0) r=bidoubiwa a=meili-bot Related to this issue: meilisearch/integration-guides#142 This PR: - gathers the changes related to the next MeiliSearch release (v0.23.0) so that this package is ready when the official release is out. - should pass the tests against the [latest pre-release of MeiliSearch](https://github.com/meilisearch/MeiliSearch/releases). - might eventually contain test failures until the MeiliSearch v0.23.0 is out.⚠️ This PR should NOT be merged until the next release of MeiliSearch (v0.23.0) is out. _This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/master/guides/pre-release-week.md) purpose._ Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com> Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com> Co-authored-by: bors[bot] <26634292+bors[bot]@users.noreply.github.com> Co-authored-by: Charlotte Vermandel <charlottevermandel@gmail.com>
bors bot
added a commit
to meilisearch/meilisearch-swift
that referenced
this issue
Oct 12, 2021
202: Changes related to the next MeiliSearch release (v0.23.0) r=bidoubiwa a=meili-bot Related to this issue: meilisearch/integration-guides#142 This PR: - gathers the changes related to the next MeiliSearch release (v0.23.0) so that this package is ready when the official release is out. - should pass the tests against the [latest pre-release of MeiliSearch](https://github.com/meilisearch/MeiliSearch/releases). - might eventually contain test failures until the MeiliSearch v0.23.0 is out.⚠️ This PR should NOT be merged until the next release of MeiliSearch (v0.23.0) is out. _This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/master/guides/pre-release-week.md) purpose._ Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com> Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com> Co-authored-by: bors[bot] <26634292+bors[bot]@users.noreply.github.com> Co-authored-by: Charlotte Vermandel <charlottevermandel@gmail.com> Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com>
bors bot
added a commit
to meilisearch/meilisearch-java
that referenced
this issue
Oct 13, 2021
218: Changes related to the next MeiliSearch release (v0.23.0) r=alallema a=meili-bot Related to this issue: meilisearch/integration-guides#142 This PR: - gathers the changes related to the next MeiliSearch release (v0.23.0) so that this package is ready when the official release is out. - should pass the tests against the [latest pre-release of MeiliSearch](https://github.com/meilisearch/MeiliSearch/releases). - might eventually contain test failures until the MeiliSearch v0.23.0 is out.⚠️ This PR should NOT be merged until the next release of MeiliSearch (v0.23.0) is out. _This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/master/guides/pre-release-week.md) purpose._ Done: - Update code sample Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com> Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com> Co-authored-by: Amélie <alallema@users.noreply.github.com> Co-authored-by: alallema <amelie@meilisearch.com>
bors bot
added a commit
to meilisearch/meilisearch-dotnet
that referenced
this issue
Oct 13, 2021
151: Changes related to the next MeiliSearch release (v0.23.0) r=curquiza a=meili-bot Related to this issue: meilisearch/integration-guides#142 This PR: - gathers the changes related to the next MeiliSearch release (v0.23.0) so that this package is ready when the official release is out. - should pass the tests against the [latest pre-release of MeiliSearch](https://github.com/meilisearch/MeiliSearch/releases). - might eventually contain test failures until the MeiliSearch v0.23.0 is out.⚠️ This PR should NOT be merged until the next release of MeiliSearch (v0.23.0) is out. _This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/master/guides/pre-release-week.md) purpose._ Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com> Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com>
23 tasks
All code samples have been implemented in the SDKs and geosearch is now merged to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This issue gathers the changes related to the v0.23.0 of MeiliSearch that will impact the integrations
Geo-search
meilisearch/meilisearch#1689
The geo-search feature will not impact the SDKs, even the strongly typed ones 🎉
However, some tests can be added if you want, not mandatory.
Instant-meilisearch is impacted. @bidoubiwa is going to implement the missing parts.
New format handling
meilisearch/meilisearch#1593
application/json
asContent-Type
to every request: this should be adapted to the concerned requests (POST and PUT). I mean only sendContent-type
forPOST
andPUT
, and not forDELETE
andGET
.@alallema will test to add
add_documents_json
,add_documents_csv
andadd_documents_ndjson
first on the Python SDK. If, after this implementation, we keep this decision, these 3 methods should be added in JS and PHP SDKs by @bidoubiwa and @alallema.All the other missing methods (in JS, Python, and PHP SDKs, but also in all the other SDKs) will lead to opening issues that the community could fix, but will not be prioritized by the integration team until another decision is made
Code samples
Some guides creating by the docs team will introduce new code samples we will need to integrate. All the SDKs with code samples are concerned.
TODO:
For the code samples:
For the geosearch implementation:
The text was updated successfully, but these errors were encountered: