Lazy index getting started suggestion #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curquiza
previously approved these changes
Oct 28, 2020
There was a problem hiding this comment.
I'm absolutely not against this simplification. It does not drastically impact other sections of the docs if I'm correct.
The only point is for the integration team: once this PR is merged, we should be ready to implement the change about the lazy index, see meilisearch/integration-guides#48. Otherwise, both getting started (from the docs and from the README) would not be consitent. The docs getting started link is now present at the top of each README, so both of them are now highly related.
dichotommy
suggested changes
Oct 29, 2020
bidoubiwa
force-pushed
the
prepare-meilisearch-11-2020
branch
from
fc64742 to
bc3e9d3
Compare
|
I found this at the bottom of my notifications list, missed it somehow. Do you still need a review? And sorry for missing this! |
|
Are we still waiting on changes to the README files, or can these changes be applied to the docs site? |
|
Hello @React-learner, |
dichotommy
suggested changes
Jan 13, 2021
bors bot
added a commit
to meilisearch/meilisearch-js
that referenced
this pull request
Jan 14, 2021
745: Update code samples searchabld and lazy index r=curquiza a=bidoubiwa Update the following code samples - document addition in getting started - searchable attribute - displayed attribute meilisearch/documentation#571 meilisearch/integration-guides#75 Co-authored-by: Charlotte Vermandel <charlottevermandel@gmail.com>
bors bot
added a commit
to meilisearch/meilisearch-ruby
that referenced
this pull request
Jan 14, 2021
138: Update code-samples r=curquiza a=curquiza meilisearch/documentation#571 meilisearch/integration-guides#75 Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com>
bors bot
added a commit
to meilisearch/meilisearch-php
that referenced
this pull request
Jan 14, 2021
130: Update code-samples r=curquiza a=curquiza meilisearch/documentation#571 meilisearch/integration-guides#75 Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com>
bors bot
added a commit
to meilisearch/meilisearch-rust
that referenced
this pull request
Jan 14, 2021
90: Update code-samples r=curquiza a=curquiza meilisearch/documentation#571 meilisearch/integration-guides#75 Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com>
curquiza
previously approved these changes
Jan 18, 2021
dichotommy
suggested changes
Jan 18, 2021
Co-authored-by: Tommy <68053732+react-learner@users.noreply.github.com>
Co-authored-by: Tommy <68053732+react-learner@users.noreply.github.com>
Co-authored-by: Tommy <68053732+react-learner@users.noreply.github.com>
Co-authored-by: Tommy <68053732+react-learner@users.noreply.github.com>
Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com>
Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com>
Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com>
bidoubiwa
force-pushed
the
lazy-suggestion
branch
from
39da4b5 to
927c039
Compare
Co-authored-by: Tommy <68053732+react-learner@users.noreply.github.com>
Co-authored-by: Tommy <68053732+react-learner@users.noreply.github.com>
dichotommy
approved these changes
Jan 18, 2021
dichotommy
added a commit
that referenced
this pull request
Jan 22, 2021
* Update upgrading guide in installation * Bump eslint from 7.17.0 to 7.18.0 (#704) Bumps [eslint](https://github.com/eslint/eslint) from 7.17.0 to 7.18.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md) - [Commits](eslint/eslint@v7.17.0...v7.18.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * Remove axios vulnerability (#703) Co-authored-by: Tommy <68053732+react-learner@users.noreply.github.com> * Lazy index getting started suggestion (#571) * Prepare documentation for release 11/2020 of MeiliSearch * Change documents references * Add lazy index to indexes main concept * Suggestion for lazy index into getting started * Fix type * Apply suggestions from code review Co-authored-by: Tommy <68053732+react-learner@users.noreply.github.com> * Update guides/introduction/quick_start_guide.md Co-authored-by: Tommy <68053732+react-learner@users.noreply.github.com> * Update .vuepress/config.js Co-authored-by: Tommy <68053732+react-learner@users.noreply.github.com> * Update references/documents.md Co-authored-by: Tommy <68053732+react-learner@users.noreply.github.com> * Remove create index code sample * Update guides/introduction/quick_start_guide.md Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com> * Update guides/main_concepts/indexes.md Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com> * Update guides/main_concepts/indexes.md Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com> * Update documents addition in getting started. Updated primary key definition * Update .vuepress/components/glossary.vue Co-authored-by: Tommy <68053732+react-learner@users.noreply.github.com> * Update guides/introduction/quick_start_guide.md Co-authored-by: Tommy <68053732+react-learner@users.noreply.github.com> * Fix styling Co-authored-by: Tommy <68053732+react-learner@users.noreply.github.com> Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com> * Update LICENSE (#709) * Update guides/advanced_guides/installation.md Co-authored-by: Tommy <68053732+react-learner@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Tommy <68053732+react-learner@users.noreply.github.com> * Update upgrading guide in installation Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Tommy <68053732+react-learner@users.noreply.github.com> Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft for lazy index in getting started.
Since this PR is waiting on meilisearch/integration-guides#48 it is but as a draft to ensure it will not be merged.