Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade scrapy 2.3.0 #67

Merged
merged 11 commits into from
Sep 21, 2020
Merged

Upgrade scrapy 2.3.0 #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
8c49d1b
Remove custom context factory
Jul 6, 2020
628d9cd
Merge branch 'master' of https://github.com/meilisearch/docs-scraper
Jul 6, 2020
86a9df7
Fix Changelog after update
Jul 6, 2020
c7acd24
Merge branch 'master' of https://github.com/meilisearch/docs-scraper
Jul 8, 2020
3ff312c
Remove nb_hits update in config file
Jul 9, 2020
c273e14
Remove commented out import
Jul 9, 2020
3fd64a8
Remove update_nb_hits related logic since is no longer used
Jul 10, 2020
6ea8b62
Fix pylint complaint
Jul 10, 2020
47987b6
Merge branch 'master' of https://github.com/meilisearch/docs-scraper
Jul 10, 2020
d0f2519
Merge branch 'master' of https://github.com/meilisearch/docs-scraper
Sep 15, 2020
e41ce85
Update scrapy to version 2.3.0
Sep 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Pipfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ verify_ssl = true
name = "pypi"

[packages]
Scrapy = "==2.2.1"
Scrapy = "==2.3.0"
selenium = "==3.141.0"
pytest = "==6.0.0"
meilisearch = "==0.12.3"
Expand Down
30 changes: 23 additions & 7 deletions Pipfile.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion scraper/src/documentation_spider.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,9 @@ def start_requests(self):
},
errback=self.errback_alternative_link)

def parse(self, response, **kwargs):
return super()._parse(response, **kwargs)

def add_records(self, response, from_sitemap):
records = self.strategy.get_records_from_response(response)
self.meilisearch_helper.add_records(records, response.url, from_sitemap)
Expand Down Expand Up @@ -176,7 +179,6 @@ def parse_from_start_url(self, response):

if self.is_rules_compliant(response):
self.add_records(response, from_sitemap=False)

else:
print("\033[94m> Ignored: from start url\033[0m " + response.url)

Expand Down