Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unwanted transform for None value to 'null' #30

Merged
merged 1 commit into from
Jun 11, 2020
Merged

Remove unwanted transform for None value to 'null' #30

merged 1 commit into from
Jun 11, 2020

Conversation

tpayet
Copy link
Member

@tpayet tpayet commented Jun 10, 2020 •
edited
Loading

Empty fields in documents are filled with 'null' string. I do not think this is a wanted behavior and we do have this issue when searching for null on docs.meilisearch.com

Screenshot 2020-06-10 at 17 53 11

here are the results with the fix

Capture d’écran 2020-06-10 à 18 07 10

@tpayet tpayet marked this pull request as ready for review June 10, 2020 15:58
@tpayet tpayet requested a review from curquiza June 10, 2020 16:02
curquiza
curquiza approved these changes Jun 11, 2020
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wooh good point!!

I added that when MeiliSearch didn't handle the null value yet, but I did'nt realize that it completely messed up the null search! 🙈

Thanks 😁

@curquiza curquiza merged commit df07723 into meilisearch:master Jun 11, 2020
@curquiza curquiza mentioned this pull request Jun 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curquiza curquiza curquiza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tpayet @curquiza