Add how to run MeiliSearch in README #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpayet
previously approved these changes
Apr 17, 2020
|
|
||
| Here is the [documentation to install and run MeiliSearch](https://docs.meilisearch.com/guides/advanced_guides/installation.html#installation). | ||
|
|
||
| _A tutorial about how to run MeiliSearch in production is coming..._ |
There was a problem hiding this comment.
So much pressure on you now
Co-Authored-By: Thomas Payet <thomas@meilisearch.com>
eskombro
approved these changes
Apr 17, 2020
README.md
Outdated
| @@ -2,7 +2,15 @@ | |||
|
|
|||
| A scraper for your documentation website that indexes the scraped content into a MeiliSearch instance. | |||
|
|
|||
| [MeiliSearch](https://github.com/meilisearch/MeiliSearch) is a powerful, fast, open-source, easy to use and deploy search engine. Both searching and indexing are highly customizable. Features such as typo-tolerance, filters, and synonyms are provided out-of-the-box | |||
|
|
|||
| This scraper is used in production and crawls the [MeiliSearch documentation](https://docs.meilisearch.com/) on each deployment. | |||
There was a problem hiding this comment.
Crawler == Downloading the web pages?
Scraper == Analyzing/indexing?
Just want to be sure about terminology. Because both terms are used widely, and mixed in sentences. SO just want to be sure you are sure about how you use them :)
There was a problem hiding this comment.
To be honest I wrote that without thinking it could have a difference 😂
I found out this difference: https://www.skylynapps.com/scrapemate/learn/help/general/difference-between-crawler-and-scraper.php
Still not really clear haha
I'm going to update the docs then, to only use words I'm sure to know 😅
|
|
||
| Here is the [documentation to install and run MeiliSearch](https://docs.meilisearch.com/guides/advanced_guides/installation.html#installation). | ||
|
|
||
| _A tutorial about how to run MeiliSearch in production is coming..._ |
eskombro
previously approved these changes
Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add precision in the readme about how to run a MeiliSearch instance (a crucial part to get the scraper worked ^^)
I add you as reviewers because it's a part I will add in the README of docs-searchbar.js and vuepress-plugin too