Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run the integration-tests on a more large pannel of python versions #290

Closed
bidoubiwa opened this issue Dec 1, 2022 · 0 comments · Fixed by #292
Closed

Run the integration-tests on a more large pannel of python versions #290

bidoubiwa opened this issue Dec 1, 2022 · 0 comments · Fixed by #292
Labels
good first issue Good for newcomers maintenance Anything related to maintenance (CI, tests, refactoring...)

Comments

@bidoubiwa
Copy link
Contributor

In the tests.yml file we are currently running the tests on these python version

  • 3.8
  • 3.9

Python 3.11 is out and it should be added in this matrix as well. Should we keep running the tests on 3.8 and 3.9?

Additionally the tests should be added in the bors.toml file and the settings of the repo.
@bidoubiwa bidoubiwa added good first issue Good for newcomers maintenance Anything related to maintenance (CI, tests, refactoring...) labels Dec 1, 2022
@brunoocasali brunoocasali mentioned this issue Dec 1, 2022
Merged
meili-bors bot added a commit that referenced this issue Dec 5, 2022
@meili-bors @brunoocasali @alallema
Merge #292
4d19848 
292: Enhancement/Action tests r=alallema a=brunoocasali

Fixes #290 

I think we can keep the last three minor releases of Python. This PR adds those last three minors to `unit_tests` and `integration_tests` actions.
The linter action runs only against the python version we have in the final docker image.

Co-authored-by: Bruno Casali <brunoocasali@gmail.com>
Co-authored-by: Amélie <alallema@users.noreply.github.com>
meili-bors bot added a commit that referenced this issue Dec 5, 2022
@meili-bors @brunoocasali @alallema
Merge #292
ebefb1e 
292: Enhancement/Action tests r=brunoocasali a=brunoocasali

Fixes #290 

I think we can keep the last three minor releases of Python. This PR adds those last three minors to `unit_tests` and `integration_tests` actions.
The linter action runs only against the python version we have in the final docker image.

Co-authored-by: Bruno Casali <brunoocasali@gmail.com>
Co-authored-by: Amélie <alallema@users.noreply.github.com>
meili-bors bot added a commit that referenced this issue Dec 6, 2022
@meili-bors @brunoocasali @alallema
Merge #292
88ec1f0 
292: Enhancement/Action tests r=bidoubiwa a=brunoocasali

Fixes #290 

I think we can keep the last three minor releases of Python. This PR adds those last three minors to `unit_tests` and `integration_tests` actions.
The linter action runs only against the python version we have in the final docker image.

Co-authored-by: Bruno Casali <brunoocasali@gmail.com>
Co-authored-by: Amélie <alallema@users.noreply.github.com>
@meili-bors meili-bors bot closed this as completed in a0e8665 Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers maintenance Anything related to maintenance (CI, tests, refactoring...)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enhancement/Action tests meilisearch/docs-scraper
1 participant
@bidoubiwa