Add implementations for non-zero integer types #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moy2010
force-pushed
the
add-impls-for-non-zero-integers
branch
from
fe9a9b7 to
483df02
Compare
moy2010
force-pushed
the
add-impls-for-non-zero-integers
branch
from
483df02 to
6525d8a
Compare
irevoire
approved these changes
Jun 19, 2023
There was a problem hiding this comment.
Hey @moy2010!
Your code is perfect and well tested!
Thanks a lot for your PR, merging.
Let me know if you need a new release, and since the new error messages introduced can only be triggered by using a previously unsupported type it’s non breaking 🎉
|
Hi, @irevoire ! No worries, I don't urgently need a new release. It's fine to let these changes come up whenever a new release is ready :). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What does this PR do?
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!