Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: NpcSaleData #951

Merged
merged 2 commits into from
Oct 29, 2024
Merged

feat: NpcSaleData #951

merged 2 commits into from
Oct 29, 2024

Conversation

kokekanon
Copy link
Collaborator

@kokekanon kokekanon commented Oct 29, 2024

Description

image

v342

2
1

pdump(g_things.getThingType(3359, ThingCategoryItem):getMeanPrice())
139

pdump(g_things.getThingType(3359, ThingCategoryItem):getNpcSaleData())
{ 
    [1] = { 
        ["name"] = "H.L.",
        ["salePrice"] = 0,
        ["currencyQuestFlagDisplayName"] = "",
        ["location"] = "Outlaw Camp",
        ["buyPrice"] = 50,
        ["currencyObjectTypeId"] = 0
    },
    [2] = { 
        ["name"] = "Raffael",
        ["salePrice"] = 450,
        ["currencyQuestFlagDisplayName"] = "",
        ["location"] = "Isle of Destiny",
        ["buyPrice"] = 0,
        ["currencyObjectTypeId"] = 0
    },
    [3] = { 
        ["name"] = "Azil",
        ["salePrice"] = 450,
        ["currencyQuestFlagDisplayName"] = "",
        ["location"] = "Darashia City",
        ["buyPrice"] = 150,
        ["currencyObjectTypeId"] = 0
    },
    [4] = { 
        ["name"] = "Baltim",
        ["salePrice"] = 450,
        ["currencyQuestFlagDisplayName"] = "",
        ["location"] = "Tyrsung",
        ["buyPrice"] = 150,
        ["currencyObjectTypeId"] = 0
    },
    [5] = { 
        ["name"] = "Brengus",
        ["salePrice"] = 450,
        ["currencyQuestFlagDisplayName"] = "",
        ["location"] = "Port Hope City",
        ["buyPrice"] = 150,
        ["currencyObjectTypeId"] = 0
    },
    [6] = { 
        ["name"] = "Cedrik",
        ["salePrice"] = 450,
        ["currencyQuestFlagDisplayName"] = "",
        ["location"] = "Liberty Bay City",
        ["buyPrice"] = 150,
        ["currencyObjectTypeId"] = 0
    },

.....

Behavior

Actual

and fix this bug anchor
dsfvsdvs

Expected

tier + rarity + fix anchor
image

Fixes

# (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Server Version: 13.40
  • Client: pr 951
  • Operating System: windows 10

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  1. I don't know if this is the right way to do this, I copied and pasted analizer. xd
local coloredText = ItemsDatabase.setColorLootMessage(text)
label:setColoredText(coloredText)
local console = modules.game_console
local consoleBuffer = console.consoleTabBar:getTabPanel(console.getTab("Server Log")):getChildById('consoleBuffer')
consoleBuffer:getLastChild():setColoredText(coloredText)
  1. I don't know if the cipsoft client uses mode, median, average or max (to take the price of the item), I chose average.

Copy link

@mehah mehah merged commit 130d909 into mehah:main Oct 29, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants