Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GNUInstallDirs and add cmake/Findphmap.cmake #941

Merged
merged 1 commit into from
Oct 20, 2024
Merged

Use GNUInstallDirs and add cmake/Findphmap.cmake #941

merged 1 commit into from
Oct 20, 2024

Conversation

jopadan
Copy link
Contributor

@jopadan jopadan commented Oct 20, 2024

Description

Move parallel-hashmap detection to cmake/Findphmap.cmake (probably needs adding a break or exit in case of failure REQUIRED flag doesn't work here)

Add include(GnuInstallDirs) for platform independent CMAKE_INSTALL_* dirs

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Test Configuration:

  • Server Version:
  • Client:
  • Operating System: Linux-6.11.4 EM64T

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@mehah mehah merged commit e4311b5 into mehah:main Oct 20, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants