Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: item duration display UI (GameThingClock) #834

Merged
merged 7 commits into from
Aug 12, 2024

Conversation

kokekanon
Copy link
Collaborator

@kokekanon kokekanon commented Jul 28, 2024

Description

I don't know if it's the best code, but it works xd

ideal would be

https://github.com/mehah/otclient/blob/main/src/client/uiitem.cpp#L29

Behavior

Actual

Do this and that doesn't happens

Expected

OTC ------------------------------- Clipsoft
otcs clipsoftdf

Fixes

# (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Server Version:
  • Client:
  • Operating System:

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@luanluciano93
Copy link
Collaborator

very good

@Nottinghster Nottinghster marked this pull request as ready for review August 12, 2024 17:46
@luanluciano93 luanluciano93 merged commit 8020e44 into mehah:main Aug 12, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants