improve: readme infos #801
Conversation
example attachParticleEffect: g_game.getLocalPlayer():attachParticleEffect("creature-effect") modules\game_attachedeffects\attachedeffects.lua
delete unnecessary print
print("No stats bars dimensions found: ", dimension, " on reloadCurrentTab()") modules\game_interface\widgets\statsbar.lua
Add comment to minimap tfs c++ (old) :
void ProtocolGame::sendWorldTime()
tfs lua (new) :
function Player.sendWorldTime(self, time)
Canary:
void ProtocolGame::sendTibiaTime(int32_t time`) modules\game_minimap\
test in clean version otc and tfs 1.5 8.6
kokekanon
changed the title
|
current: new readme (fix) NICE WORK!!! 💗 |
majestyotbr
changed the title
|
If you find it necessary, you can clean up the features, there are many things that are unnecessary to inform and only make it more polluted. type: c++20, Optimized Terminal, Idle Animation Support, Some bugs fixed contained in edubart/otclient etc... you can replace it with text saying this client contains XYZ optimizations compared to otc edubart, Unfortunately, I'm terrible at this, if not, it would help you to describe it. |
|
Like this?
drop-down menu
moved to drop-down menu :
delete :
Posible delete? or moved to drop-down menu ?:
|
|
@kokekanon |
|
I think it's better to put Support HTML/CSS syntax, because it doesn't support all the features of html/css. Video.Sem.Titulo.Feito.Com.O.Clipchamp.1.mp4There's this video too if you want to post it. |
|
@kokekanon Awesome work! |
|
wiki Attached Effects https://github.com/user-attachments/files/16553549/README.md |
There was a problem hiding this comment.
LGTM! Just a quick suggestion for better Git flow in future PRs: it might be more effective to keep PRs smaller and focused on specific contexts. For example, in this case, you could have one PR for the readme.txt and another for the shopSERVER. Working on each task separately and opening individual PRs for each would make the review process less tedious and time-consuming. Using Git Flow could be a good approach—create a branch for the feature and then merge the sub-tasks into this feature branch.
note: when modifying the readme I realized that some comments were missing and added the shop server part
My part is ready, someone needs to modify this information that I'm unaware of.
I did it about 3 months ago, I no longer have access to it to improve it.to the main repo wiki
1) improve: Readme
demo :
https://github.com/kokekanon/otclient.readme/tree/readme3
requested by mehah about 3 months ago haha
Screenshot:
....
....
....
....
....
....
....
....
2) Add comments
g_game.getLocalPlayer():attachParticleEffect("creature-effect")void ProtocolGame::sendWorldTime()tfs lua (new) :
function Player.sendWorldTime(self, time)Canary:
void ProtocolGame::sendTibiaTime(int32_t time`)3) Add shop v8 server-side
test in clean version otc and tfs 1.5 8.6