Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1056, correct variable name #1059

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Conversation

Zbizu
Copy link
Contributor

@Zbizu Zbizu commented Jan 19, 2025

Description

  1. closes Minor UI issue with tooltips overlaping clickable elements. #1056 by setting phantom property to tooltips
    (this makes the button read hover event despite being covered by the tooltip)
  2. corrects a typo in variable name

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested

  1. I set g_effects.fadeOut to 3000 in modules/corelib/ui/tooltip.lua
  2. in init.lua I enabled status in Services
  3. this was sent by my webservice (in order to reproduce the exact scenario described in the issue):
function sendMessage($message) {
	$response = json_encode($message);
	die($response);
}

// case 'eventschedule':
// getEventSchedule();
// break;
function getEventSchedule() {
	$eventlist = [];
	$ev = array(
		'colorlight' => "#FFFFFF",
		'colordark' => "#000000",
		'description' => "EVENT EVENT EVENT EVENT EVENT EVENT EVENT EVENT EVENT EVENT EVENT EVENT EVENT EVENT EVENT EVENT EVENT EVENT EVENT EVENT EVENT EVENT EVENT EVENT EVENT EVENT EVENT",
		'displaypriority' => 1,
		'isseasonal' => false,
		'name' => "TEST",
		'startdate' => 1737304005,
		'enddate' => 1747304005,
		'specialevent' => 0
	);
	array_push($eventlist, $ev);
	sendMessage(array(
		'eventlist' => $eventlist, 
		'lastupdatetimestamp' => time()
	));
}
  1. the button was not clickable as described in the issue, setting phantom property to the tooltip resolved this problem

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@luanluciano93 luanluciano93 merged commit 7025f9e into mehah:main Jan 20, 2025
12 checks passed
@Zbizu Zbizu deleted the fix-tooltip branch January 20, 2025 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minor UI issue with tooltips overlaping clickable elements.
3 participants