perf: reduce the unnecessary use of ref
#526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
|
Thank you for the PR. I just need to doublecheck #502 with this change since I think they might be related. |
|
@megasanjay Thank you for your review. 💚 I have looked into issue #502 and believe it is unrelated to this issue. I have reproduced the problem in the playground and found a solution. I will open another PR to resolve this issue as soon as possible. |
megasanjay
approved these changes
Mar 17, 2024
megasanjay
added a commit
that referenced
this pull request
Mar 17, 2024
* fix: ensure `loadLottie` is called after the component mounted (#527) * fix: ensure `loadLottie` invoke after `lottieAnimationContainer` is mounted * refactor: remove unnecessary `nextTick` * perf: educe the unnecessary use of `ref` (#526) Co-authored-by: Sanjay Soundarajan <sanjay.16@live.com> * refactor: switch to smaller dependencies to reduce bundle size (#525) * 🐛 fix: performance improvements and suspense bug fixes * 🔖 chore: prep for releasing v3.3 * 🔖 chore: prep for releasing v3.3 beta --------- Co-authored-by: Alex Liu <dsa1314@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inside
<Vue3Lottie>,animationDatais used to store the JSON data passed by the user:vue3-lottie/packages/vue3-lottie/src/vue3-lottie.vue
Line 116 in d1c38f8
I checked the context, and
refseems this isn't a necessary presence. I tried making it a regular variable instead of a Vueref, and there was a significant performance improvement.After this PR, using
dog.jsonas an example, it can reduce the time by about 25% (measuring the execution ofloadLottie()).