Fix import screen toggles #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix toggle double click event (nested `fields` property) - do not call `prepareForm` for every render but only on init (otherwise all toggles reset to `default: true`
moved form definition to `componentWillMount`
haraldox
commented
Feb 8, 2018
| default: true, | ||
| options: s, | ||
| import: [...this.props.services.filter(s => s.recipe).map(s => ({ | ||
| fields: { |
There was a problem hiding this comment.
that did the trick :)
haraldox
commented
Feb 8, 2018
| @@ -74,7 +74,6 @@ export default class Import extends Component { | |||
| } | |||
|
|
|||
| render() { | |||
| this.form = this.prepareForm(); | |||
There was a problem hiding this comment.
would otherwise reset toggles to true on submit
adlk
approved these changes
Feb 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
import screen toggles did not work because of missing nested
fields:property in form instance ofmobx-react-form. also removedprepareForm()and moved form definition tocomponentWillMount()Motivation and Context
user should be able to select which services to import
How Has This Been Tested?
manually during signup and using route
#auth/signup/importScreenshots (if appropriate):
Types of changes
Checklist:
$ yarn lint).