This repository has been archived by the owner on Oct 23, 2023. It is now read-only.
feat: allow users to add new pages #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@marionebl Nice one! Is there a reason why Undo/Redo Operations do not work for renaming and creating pages? I think we should support that, too. Or what’s your opinion? And when I rename a page now, the file is still named "new-page-7.yaml" inside the Alva folder. Can we use the displayed name as filename here, too? I thought we already had some logic for that... |
|
Update: As the delete-page function is not built for the moment, an Undo/Redo does not make a lot of sense. The renaming issue with the files will be done in a separate PR. |
tilmx
approved these changes
May 5, 2018
Palmaswell
pushed a commit
that referenced
this pull request
May 7, 2018
Palmaswell
pushed a commit
that referenced
this pull request
May 7, 2018
fix: avoid jumping heights via text-overflow: ellipsis feat: page overview (#399) :heart: @Palmaswell * feat: add page overview * chore: update lock file * fix: update usage of arrow icons * fix: be consistent about event listener names * fix: consistently indicate texts can be edited * fix: truncate too long page titles * fix: adjust project title styling and page inset * fix: visually align chrome title * fix: adapt styling of view-switch * fix: ensure page list title clicks enable edit mode * feat: show view button only page detail view * fix: visually align chrome title * feat: wrap the page list for narrow viewports * fix: manage preview resizing lifecycle correctly feat: add floating-button component (#425) * feat: add floating-button component * fix: add plus icon to icon library feat: allow users to add new pages (#426) fix(highlight): include blur behaviour feat(preview-renderer): Rebase master status
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend the page list view with a floating button that adds a new page to the list
Usefulness very limited via #387, let's tackle this next
Fixes #24
Screencast