fix: avoid infinite loops when dragging elements on themselves

meetalva · May 7, 2018 · 5b45225 · 5b45225
1 parent 562e4df
commit 5b45225
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/src/store/command/element-location-command.ts b/src/store/command/element-location-command.ts
@@ -194,6 +194,11 @@ export class ElementLocationCommand extends ElementCommand {
 			return false;
 		}
 
+		// Do not try to add an element to itself
+		if (this.element === this.parent) {
+			return false;
+		}
+
 		this.element.setParent(this.parent, this.slotId, this.index);
 		this.memorizeElementIds();