Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dashboard): Submit forms on Cmd + Enter #9623

Merged
merged 6 commits into from
Oct 17, 2024
Merged

feat(dashboard): Submit forms on Cmd + Enter #9623

merged 6 commits into from
Oct 17, 2024

Conversation

kasperkristensen
Copy link
Contributor

@kasperkristensen kasperkristensen commented Oct 16, 2024 •
edited
Loading

What

  • Changes all forms to only submit on Cmd/Ctrl + Enter instead of just Enter.
  • Cleans up the position of submit/cancel buttons in many FocusModals that still had them in the header.
  • Fixes responsiveness of multiple forms
  • Removes the SplitView component, and replaces its usages with StackedDrawer/Modal to align the UX across the project.

Resolves CC-103, CC-535

@kasperkristensen kasperkristensen requested a review from a team as a code owner October 16, 2024 19:37
@vercel Vercel
Copy link

vercel bot commented Oct 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2024 9:24am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Oct 17, 2024 9:24am
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Oct 17, 2024 9:24am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Oct 17, 2024 9:24am
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Oct 17, 2024 9:24am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Oct 17, 2024 9:24am
resources-docs ⬜️ Ignored (Inspect) Visit Preview Oct 17, 2024 9:24am

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 16, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 5e4479a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

olivermrbl
olivermrbl approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels good, nice work @kasperkristensen 💪

@kodiakhq kodiakhq bot merged commit 1d540af into develop Oct 17, 2024
23 checks passed
@kodiakhq kodiakhq bot deleted the feat/change-submit-keybind branch October 17, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivermrbl olivermrbl olivermrbl approved these changes

@sgirones sgirones Awaiting requested review from sgirones sgirones is a code owner automatically assigned from medusajs/engineering

@riqwan riqwan Awaiting requested review from riqwan riqwan is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
automerge team: medusa type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kasperkristensen @olivermrbl