-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dashboard): reservation inventory details #9535
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Skipped Deployments
|
packages/admin/dashboard/src/routes/reservations/reservation-detail/reservation-detail.tsx
Outdated
Show resolved
Hide resolved
@@ -23,6 +24,9 @@ export const ReservationDetail = () => { | |||
} | |||
) | |||
|
|||
// TEMP: fetch directly since the fields are not populated with reservation call |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
q: where would it be more correct to fetch the item details?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what endpoint would you suggest, this is fetching inventory item
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am asking wrt. the comment you put here - what would be the optimal approach to make this not TEMP
? Is it just adding the inventory_item
field when fetching the reservation?
If so we should maybe either include that in this PR or create a separate task so that can be fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it just adding the inventory_item field when fetching the reservation?
Yup, ideally we would want that but with this approach computed properties such as reserved_quantity
are not being returned. I'll open a ticket.
What
FIXES CC-595