Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboard): reservation inventory details #9535

Merged
merged 2 commits into from
Oct 14, 2024

Conversation

fPolic
Copy link
Contributor

@fPolic fPolic commented Oct 11, 2024

What

  • display data in inventory details section of the reservation details page

FIXES CC-595

@fPolic fPolic requested a review from a team as a code owner October 11, 2024 12:13
Copy link

changeset-bot bot commented Oct 11, 2024

⚠️ No Changeset found

Latest commit: f8df1af

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Oct 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 14, 2024 8:44am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Oct 14, 2024 8:44am
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Oct 14, 2024 8:44am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Oct 14, 2024 8:44am
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Oct 14, 2024 8:44am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Oct 14, 2024 8:44am
resources-docs ⬜️ Ignored (Inspect) Visit Preview Oct 14, 2024 8:44am

@@ -23,6 +24,9 @@ export const ReservationDetail = () => {
}
)

// TEMP: fetch directly since the fields are not populated with reservation call
Copy link
Collaborator

@srindom srindom Oct 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

q: where would it be more correct to fetch the item details?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what endpoint would you suggest, this is fetching inventory item

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am asking wrt. the comment you put here - what would be the optimal approach to make this not TEMP? Is it just adding the inventory_item field when fetching the reservation?

If so we should maybe either include that in this PR or create a separate task so that can be fixed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it just adding the inventory_item field when fetching the reservation?

Yup, ideally we would want that but with this approach computed properties such as reserved_quantity are not being returned. I'll open a ticket.

@kodiakhq kodiakhq bot merged commit 75475f7 into develop Oct 14, 2024
23 checks passed
@kodiakhq kodiakhq bot deleted the fix/reservation-ii-details branch October 14, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants