Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core-flows, link-module): product <> inventory delete cascades #9528

Merged
merged 18 commits into from
Oct 14, 2024
Merged

fix(core-flows, link-module): product <> inventory delete cascades #9528

merged 18 commits into from
Oct 14, 2024

Conversation

fPolic
Copy link
Contributor

@fPolic fPolic commented Oct 10, 2024 •
edited
Loading

What

  • remove cascade delete of inventory items on product delete
  • implement inventory deletion in product/variant delete workflows with checks:
    • product/variant cannot be deleted if there are reservations associated with their inventory items
    • inventory item will be cascade deleted if it's not used by other variants (that are not being deleted in the current flow)

FIXES CC-581 CC-582

@vercel Vercel
Copy link

vercel bot commented Oct 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 14, 2024 1:52pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Oct 14, 2024 1:52pm
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Oct 14, 2024 1:52pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Oct 14, 2024 1:52pm
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Oct 14, 2024 1:52pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Oct 14, 2024 1:52pm
resources-docs ⬜️ Ignored (Inspect) Visit Preview Oct 14, 2024 1:52pm

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 10, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 8b63afa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@fPolic fPolic marked this pull request as ready for review October 10, 2024 17:50
@fPolic fPolic requested a review from a team as a code owner October 10, 2024 17:50
olivermrbl
olivermrbl approved these changes Oct 12, 2024
View reviewed changes
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💪

srindom
srindom approved these changes Oct 14, 2024
View reviewed changes
Copy link
Collaborator

@srindom srindom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kodiakhq kodiakhq bot merged commit 809c851 into develop Oct 14, 2024
23 checks passed
@kodiakhq kodiakhq bot deleted the fix/product-inventory-delete-cascades branch October 14, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivermrbl olivermrbl olivermrbl approved these changes

@srindom srindom srindom approved these changes

@riqwan riqwan Awaiting requested review from riqwan riqwan is a code owner automatically assigned from medusajs/engineering

@christiananese christiananese Awaiting requested review from christiananese christiananese is a code owner automatically assigned from medusajs/engineering

@carlos-r-l-rodrigues carlos-r-l-rodrigues Awaiting requested review from carlos-r-l-rodrigues

@adrien2p adrien2p Awaiting requested review from adrien2p

Assignees
No one assigned
Labels
automerge team: medusa type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fPolic @srindom @adrien2p @olivermrbl