Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hover states on filters and chip groups #9511

Merged
merged 4 commits into from
Oct 9, 2024
Merged

Conversation

srindom
Copy link
Collaborator

@srindom srindom commented Oct 9, 2024

What

Hovering a button now changes background of entire "x"-area
https://github.com/user-attachments/assets/b77e7436-c3c1-4bfc-a930-efbe24fd15dc
Previously only a small square behind the x would hold a hover state.

Hover states on filter displays
https://github.com/user-attachments/assets/a1c0a52b-28d9-46b9-a389-ce87ca942fa3

A few modifications:

  1. The popover trigger is now only active on the value segment of a filter group.
  2. Only the value segment of a filter group is clickable and has a hover state.
  3. Similar to the chip group the entire "close" area segment of the group is active.
  4. Introduced a Popover Anchor so that when a filter is applied the popover will first show from the beginning of the filter group. The next time it will show from the value segment of the filter group.

Fixes CC-534
Fixes CC-108

Copy link

changeset-bot bot commented Oct 9, 2024

⚠️ No Changeset found

Latest commit: 6699a13

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Oct 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2024 2:25pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Oct 9, 2024 2:25pm
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Oct 9, 2024 2:25pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Oct 9, 2024 2:25pm
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Oct 9, 2024 2:25pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Oct 9, 2024 2:25pm
resources-docs ⬜️ Ignored (Inspect) Visit Preview Oct 9, 2024 2:25pm

Copy link
Contributor

@fPolic fPolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@srindom srindom merged commit 0e11e89 into develop Oct 9, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants