Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove extra saving on serialization which breaks the chain #9465

Merged
merged 4 commits into from
Oct 5, 2024
Merged

fix: Remove extra saving on serialization which breaks the chain #9465

merged 4 commits into from
Oct 5, 2024

Conversation

adrien2p
Copy link
Member

@adrien2p adrien2p commented Oct 4, 2024

What
The extra serialization check hapen to break the serialization chain by reusing already serialized entities when they have been serialized from a different parents sequence

@vercel Vercel
Copy link

vercel bot commented Oct 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference 🔄 Building (Inspect) Visit Preview 💬 Add feedback Oct 5, 2024 7:38am
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 5, 2024 7:38am
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Oct 5, 2024 7:38am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Oct 5, 2024 7:38am
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Oct 5, 2024 7:38am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Oct 5, 2024 7:38am
resources-docs ⬜️ Ignored (Inspect) Visit Preview Oct 5, 2024 7:38am

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 4, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: f5ac366

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@adrien2p adrien2p marked this pull request as ready for review October 4, 2024 09:10
@adrien2p adrien2p requested a review from a team as a code owner October 4, 2024 09:10
@adrien2p
Copy link
Member Author

adrien2p commented Oct 4, 2024

Cc @shahednasser @olivermrbl

@kodiakhq kodiakhq bot merged commit ffc35f2 into develop Oct 5, 2024
23 checks passed
@kodiakhq kodiakhq bot deleted the fix/mikro-orm-serializer-to-deep branch October 5, 2024 07:54
panalgin pushed a commit to vennyx-org/medusa that referenced this pull request Oct 7, 2024
@adrien2p @panalgin
fix: Remove extra saving on serialization which breaks the chain (med…
47d50ab 
…usajs#9465)

**What**
The extra serialization check hapen to break the serialization chain by reusing already serialized entities when they have been serialized from a different parents sequence
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivermrbl olivermrbl olivermrbl approved these changes

@riqwan riqwan Awaiting requested review from riqwan riqwan is a code owner automatically assigned from medusajs/engineering

@christiananese christiananese Awaiting requested review from christiananese christiananese is a code owner automatically assigned from medusajs/engineering

@carlos-r-l-rodrigues carlos-r-l-rodrigues Awaiting requested review from carlos-r-l-rodrigues carlos-r-l-rodrigues is a code owner automatically assigned from medusajs/engineering

@thetutlage thetutlage Awaiting requested review from thetutlage

Assignees
No one assigned
Labels
automerge team: medusa type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adrien2p @olivermrbl