Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(cli): Update start description #9448

Merged
merged 2 commits into from
Oct 4, 2024
Merged

chore(cli): Update start description #9448

merged 2 commits into from
Oct 4, 2024

Conversation

adrien2p
Copy link
Member

@adrien2p adrien2p commented Oct 3, 2024 •
edited
Loading

What
Update description of the start command

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 3, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 17e30a7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@adrien2p adrien2p marked this pull request as ready for review October 3, 2024 11:04
@adrien2p adrien2p requested a review from a team as a code owner October 3, 2024 11:04
@vercel Vercel
Copy link

vercel bot commented Oct 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference 🔄 Building (Inspect) Visit Preview 💬 Add feedback Oct 4, 2024 1:43pm
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2024 1:43pm
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Oct 4, 2024 1:43pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Oct 4, 2024 1:43pm
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Oct 4, 2024 1:43pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Oct 4, 2024 1:43pm
resources-docs ⬜️ Ignored (Inspect) Visit Preview Oct 4, 2024 1:43pm

shahednasser
shahednasser approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@shahednasser shahednasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a suggestion

packages/cli/medusa-cli/src/create-cli.ts Outdated Show resolved Hide resolved
@adrien2p @shahednasser
Update packages/cli/medusa-cli/src/create-cli.ts
17e30a7 
Co-authored-by: Shahed Nasser <shahednasser@gmail.com>
@kodiakhq kodiakhq bot merged commit eea2bfd into develop Oct 4, 2024
23 checks passed
@kodiakhq kodiakhq bot deleted the fix/cli-start-desv branch October 4, 2024 15:11
panalgin pushed a commit to vennyx-org/medusa that referenced this pull request Oct 7, 2024
@adrien2p @panalgin
chore(cli): Update start description (medusajs#9448)
1394c34 
**What**
Update description of the start command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahednasser shahednasser shahednasser approved these changes

@riqwan riqwan Awaiting requested review from riqwan riqwan is a code owner automatically assigned from medusajs/engineering

@christiananese christiananese Awaiting requested review from christiananese christiananese is a code owner automatically assigned from medusajs/engineering

@kasperkristensen kasperkristensen Awaiting requested review from kasperkristensen kasperkristensen is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
automerge team: medusa type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adrien2p @shahednasser @olivermrbl