Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dashboard, fulfilment): fulfilment providers enabled check #9415

Merged
merged 3 commits into from
Oct 2, 2024
Merged

fix(dashboard, fulfilment): fulfilment providers enabled check #9415

merged 3 commits into from
Oct 2, 2024

Conversation

fPolic
Copy link
Contributor

@fPolic fPolic commented Oct 1, 2024

What

  • hide disabled fulfilment providers on the admin
  • check if the fulfilment provider has an identifier when loading providers

FIXES CC-549

@fPolic fPolic requested a review from a team as a code owner October 1, 2024 15:38
@vercel Vercel
Copy link

vercel bot commented Oct 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 7:56am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Oct 2, 2024 7:56am
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Oct 2, 2024 7:56am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Oct 2, 2024 7:56am
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Oct 2, 2024 7:56am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Oct 2, 2024 7:56am
resources-docs ⬜️ Ignored (Inspect) Visit Preview Oct 2, 2024 7:56am

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 1, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 1280733

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

olivermrbl
olivermrbl approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add the same two checks for payment providers?

@fPolic
Copy link
Contributor Author

fPolic commented Oct 2, 2024

@olivermrbl added!

@kodiakhq kodiakhq bot merged commit ab7e71a into develop Oct 2, 2024
23 checks passed
@kodiakhq kodiakhq bot deleted the fix/fulfillment-providers-enabled-check branch October 2, 2024 14:50
panalgin pushed a commit to vennyx-org/medusa that referenced this pull request Oct 7, 2024
@fPolic @panalgin
fix(dashboard, fulfilment): fulfilment providers enabled check (medus…
b1c6911 
…ajs#9415)

**What**
- hide disabled fulfilment providers on the admin
- check if the fulfilment provider has an identifier when loading providers

---

FIXES CC-549
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivermrbl olivermrbl olivermrbl approved these changes

@sradevski sradevski Awaiting requested review from sradevski sradevski is a code owner automatically assigned from medusajs/engineering

@christiananese christiananese Awaiting requested review from christiananese christiananese is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
automerge team: medusa type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fPolic @olivermrbl