Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Poorva | Refactor codegenerator. #207

Merged
merged 3 commits into from
Oct 31, 2021
Merged

Poorva | Refactor codegenerator. #207

merged 3 commits into from
Oct 31, 2021

Conversation

Poorva17
Copy link
Contributor

@Poorva17 Poorva17 commented Jul 2, 2021

  1. Extract Command and Query as separate entities.
  2. Extract ParamBuilder and ParamDetails as domain entity hold param data.
  3. Generate method of CodeGenerator accepts list of SQLModel now. This can be leveraged further when multiple SQLModels map to one Result class.

@sonarcloud
Copy link

sonarcloud bot commented Jul 2, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kdabir kdabir merged commit 8a5d96e into medly:master Oct 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdabir kdabir kdabir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Poorva17 @kdabir