Add machine name to grpc #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng a global variable that checks whether snr is created for a machine. Signed-off-by: Michael Shitrit <mshitrit@redhat.com>
|
Skipping CI for Draft Pull Request. |
|
/test 4.13-openshift-e2e |
2 similar comments
|
/test 4.13-openshift-e2e |
|
/test 4.13-openshift-e2e |
|
/lgtm |
slintes
requested changes
Jan 5, 2024
Signed-off-by: Michael Shitrit <mshitrit@redhat.com>
Signed-off-by: Michael Shitrit <mshitrit@redhat.com> Signed-off-by: Michael Shitrit <mshitrit@redhat.com>
|
/test 4.13-openshift-e2e |
Signed-off-by: Michael Shitrit <mshitrit@redhat.com>
|
/test 4.14-openshift-e2e |
slintes
requested changes
Jan 9, 2024
…ect context Signed-off-by: Michael Shitrit <mshitrit@redhat.com>
|
/test 4.14-openshift-e2e |
slintes
approved these changes
Jan 10, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mshitrit, slintes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ECOPROJECT-1784
As a Followup for this PR Add machine name to grpc request in order to remove workaround of using a global variable that checks whether snr is created for a machine.