Skip to content

Commit

Permalink
Simplify naming for condition
Browse files Browse the repository at this point in the history
Currently when SNR is disabled because of missing configuration, the
condition's reason is "SNRDisabledConfigurationNotFound", however

- we already know it's about SNR
- we know, from the type, that is about "Disable"

so we can simplify the `reason` to "ConfigurationNotFound".

ECOPROJECT-2026

Signed-off-by: Carlo Lobrano <c.lobrano@gmail.com>
  • Loading branch information
clobrano authored and openshift-cherrypick-robot committed Jul 5, 2024
1 parent 77ee799 commit c3b8c51
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion controllers/selfnoderemediation_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ const (
remediationSkippedNodeNotFound conditionReason = "RemediationSkippedNodeNotFound"

// Other Reasons
snrDisabledNoConfig conditionReason = "SNRDisabledConfigurationNotFound"
snrDisabledNoConfig conditionReason = "ConfigurationNotFound"
)

type remediationPhase string
Expand Down

0 comments on commit c3b8c51

Please sign in to comment.