Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test #245

Merged
merged 4 commits into from
Sep 23, 2024
Merged

Fix test #245

merged 4 commits into from
Sep 23, 2024

Conversation

robkam
Copy link
Member

@robkam robkam commented Jun 13, 2024

Fixes failing test in #240

robkam added 3 commits June 13, 2024 13:56
until a better solution is to hand
until a better solution is found
@robkam robkam marked this pull request as ready for review June 13, 2024 13:12
Copy link

sourcery-ai bot commented Jun 13, 2024

🧙 Sourcery is reviewing your pull request!


Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

This was referenced Jun 13, 2024
I'm out of my depth with Poetry (virtual environment) needing pipx and pip works as far as I can make out.
@robkam robkam mentioned this pull request Jun 13, 2024
@randomnetcat
Copy link
Collaborator

Looks good.

@randomnetcat randomnetcat merged commit 701c6e4 into python3 Sep 23, 2024
5 checks passed
@randomnetcat randomnetcat deleted the robkam-patch-1 branch September 23, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants