Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I was trying to use this plugin for a Python 3.7 project and ran into an issue because of the use of
functools.cached_property
(which is new in 3.8).Here is a PR that adds a small note in the install section of the README, plus a setting in
setup.py
to prevent installing the plugin on incompatible python versions (see https://packaging.python.org/guides/distributing-packages-using-setuptools/#python-requires).A better fix might be to remove the dependency on
cached_property
but that might require more effort whereas this seems like a quick and easy fix.Thanks ✨