Skip to content
This repository has been archived by the owner on Aug 30, 2021. It is now read-only.

Supporting NodeJS v4 in Travis CI #906

Merged
merged 3 commits into from
Sep 16, 2015

Conversation

lirantal
Copy link
Member

Adding support for nodejs v4 and allowing it to fail without failing the complete build for CI.
Closes #902.

@lirantal lirantal self-assigned this Sep 11, 2015
@lirantal lirantal added this to the 0.4.2 milestone Sep 11, 2015
@lirantal
Copy link
Member Author

is it possible this build is actually failing because it doesn't enforce the matrix directive there to allow failures because it's not in the master branch? I have some doubts because it had no problems identifying that we have a new build now for nodejs v4

@lirantal
Copy link
Member Author

Ok, there we go. Now the build passes even though NodeJS v4 is failing. This way we can track it.
@ilanbiala @codydaig let's continue with that to track v4 ready-ness?

@mleanos
Copy link
Member

mleanos commented Sep 12, 2015

@lirantal Very well done.. Thank you! 👍

@codydaig
Copy link
Member

@lirantal LGTM!
:-D Learn something new everyday.

@ilanbiala
Copy link
Member

LGTM.

@lirantal did you see the warning about the legacy infrastructure on the build log page? Is there anything we use sudo for? If not, we might as well add sudo: false to the .travis.yml file as well. We would also be able to turn on caching.

cache:
  apt: true
  directories:
  - node_modules/
  - public/lib/

@ilanbiala
Copy link
Member

@lirantal not sure if you saw, but I used the caching and new containerized setup for the generator and it speeds up builds pretty quickly. I think you should try it out before merging this in without it.

@lirantal
Copy link
Member Author

@ilanbiala
I saw it was failing but didn't yet review it fully.
Sure I'll make the changes with the caching too and we will take this for a spin, thanks!

…ng sudo to false as it's not used for anything during the build
@lirantal
Copy link
Member Author

Looks like we are good now @ilanbiala

@ilanbiala
Copy link
Member

@lirantal LGTM.

@codydaig
Copy link
Member

LGTM

lirantal added a commit that referenced this pull request Sep 16, 2015
@lirantal lirantal merged commit be3622b into meanjs:master Sep 16, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants