-
Notifications
You must be signed in to change notification settings - Fork 2k
Conversation
…the complete build for CI
is it possible this build is actually failing because it doesn't enforce the |
Ok, there we go. Now the build passes even though NodeJS v4 is failing. This way we can track it. |
@lirantal Very well done.. Thank you! 👍 |
@lirantal LGTM! |
LGTM. @lirantal did you see the warning about the legacy infrastructure on the build log page? Is there anything we use
|
@lirantal not sure if you saw, but I used the caching and new containerized setup for the generator and it speeds up builds pretty quickly. I think you should try it out before merging this in without it. |
@ilanbiala |
…ng sudo to false as it's not used for anything during the build
37818bd
to
97d7eb7
Compare
Looks like we are good now @ilanbiala |
@lirantal LGTM. |
LGTM |
Supporting NodeJS v4 in Travis CI
Adding support for nodejs v4 and allowing it to fail without failing the complete build for CI.
Closes #902.