Grunt - fail the build if a task fails #762
Conversation
| @@ -208,7 +208,7 @@ module.exports = function (grunt) { | |||
| require('load-grunt-tasks')(grunt); | |||
|
|
|||
| // Making grunt default to force in order not to break the project. | |||
There was a problem hiding this comment.
Update the comment too, but can't we just delete it from the file?
There was a problem hiding this comment.
about the comment yeah, but we have this:
grunt.option('force', false);
if we leave it there in the gruntfile then even if you do grunt test --force the force option won't override it and it will force the build to fail in any case. If we do remove this option then grunt indeed defaults to failing tests but you can override it with the --force option from cmdline.
WDYT we should choose?
There was a problem hiding this comment.
I think letting people override from cmd is better because the cmd is already open to run grunt anyway.
|
and yay, we finally have some build fails. |
… can fail any task that is failing and thus fail the build in case of any issues in tests, jshint conventions, and so on
|
We need to update the travis config then to install SASS properly. That's what this PR is failing on. |
|
Yep, noticed.
|
lirantal
force-pushed
the
feature/grunt_fail_on_failures
branch
from
3d61836 to
ad31495
Compare
|
LGTM |
| @@ -6,3 +6,6 @@ env: | |||
| - NODE_ENV=travis | |||
| services: | |||
| - mongodb | |||
| before_install: | |||
| - gem update --system | |||
| - gem install sass --version "=3.3.7" | |||
lirantal
force-pushed
the
feature/grunt_fail_on_failures
branch
from
ad31495 to
dd254e1
Compare
|
LGTM now. |
|
@ilanbiala, Guys We should really get this one pushed in quick because our CI is simply not reliable anymore.
So let's try to push this in ASAP so we can add some trust to the travis-ci safety-net |
|
@lirantal I don't see any issues with it, let's merge it in now no? |
|
Cool |
Grunt - fail the build if a task fails
Updating grunt 'force' option to default/force it to false so that we can fail any task that is failing and thus fail the build in case of any issues in tests, jshint conventions, and so on.
This ensures that our CI process is catching any issues.