This repository has been archived by the owner on Aug 30, 2021. It is now read-only.
Adding ssl support back into 0.4.0 #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -2,19 +2,36 @@ | |||
|
|
|||
| // Load the module dependencies | |||
| var config = require('../config'), | |||
| path = require('path'), | |||
| path = require('path'), | |||
|
@jloveland why |
jloveland
force-pushed
the
generate-sslcerts
branch
from
6c994e9 to
022ee83
Compare
|
@ilanbiala, this is just a preference..most projects I work on put all the scripts into a |
|
@jloveland honestly I think it just comes down to it rolling off the tongue easier when telling other people and it seeming more natural because it's a folder of scripts. |
jloveland
force-pushed
the
generate-sslcerts
branch
from
022ee83 to
3e1d0b5
Compare
|
@ilanbiala I changed |
|
@lirantal LGTY? |
|
looks ok |
ilanbiala
added a commit
that referenced
this pull request
May 28, 2015
Add SSL support back into 0.4.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding ssl back in, moving scripts to script folder so we can ./script/gereratate-ssl-certs.sh