Skip to content
This repository has been archived by the owner on Aug 30, 2021. It is now read-only.

added dependencies to package.json #346

Closed
wants to merge 4 commits into from
Closed

Conversation

techunits
Copy link

There was few problem in the dependency list in the master branch, now rectified with this commit. Please review.

@ilanbiala
Copy link
Member

Can you revert the whitespace changes?

@techunits
Copy link
Author

Updated the file as per suggestions, please review.

@ilanbiala
Copy link
Member

@techunits thanks. Which packages specifically did you add to fix the errors? What errors were you facing?

@techunits
Copy link
Author

"libmime": "~0.1.6"
"hyperquest": "~1.0.1",
"base64-url": "~1.1.0",
"buildmail": "~1.2.0",

Those packages was requested while starting application and was missing from package.json list.

@ilanbiala
Copy link
Member

@techunits I haven't had to add any of those...and I don't think anyone else has had to.

@lirantal
Copy link
Member

lirantal commented Jan 6, 2015

@techunits as @ilanbiala said, I'm not sure these packages were required. Can you show some output log errors for that? the travis build environment also does npm install IIRC and there weren't any build failures recently due to packages missing

@lirantal
Copy link
Member

lirantal commented Jan 6, 2015

I just did a fresh install of meanjs with the 'master' branch and everything works fine out of the box. @techunits let us know please if you think this is still relevant.

@lirantal lirantal closed this Jan 6, 2015
@techunits
Copy link
Author

Now it seems to be working from after taking checkout from master branch just now. Thanks a lot.

pdfowler pushed a commit to pdfowler/mean that referenced this pull request Jan 19, 2016
pdfowler pushed a commit to pdfowler/mean that referenced this pull request Jan 19, 2016
… mobile/develop

# By Rykov Serge
# Via Rykov Serge
* 'mobile/develop' of bitbucket.org:outset_inc/outset:
  profile display name changed
  add activity issues done meanjs#345, meanjs#346, meanjs#347, 363
  meanjs#347, added new field distance driven, saving it to props.
  fixed isue when we add custom truck and there is no logo for it, displaying text, if there is a logo - displaying only logo
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants