-
Notifications
You must be signed in to change notification settings - Fork 2k
Conversation
I'm using this patch set and it seems to work without issues. Thanks for sharing. |
This has been updated to leverage public/config.js. I changed the default to false, as I am told this is the more common implementation. I will be adding it to generator with a param as part of the application setup. |
This is very helpful! With some more readings, I feel I may be wrong about what I said above. |
I vote we leave 'false' as default. I don't believe SEO nor pretty URLs are going to be of importance to most applications. |
@tylerdmace most care about pretty URLs and SEO, because that's how you grow. Besides it doesn't add much trouble, just that you add 1 route that sends the index.html template instead of a 404, and you pass back the original url and let Angular do all the routing other than API. |
There's no way to easily gauge the implementation type of most MEAN applications so I digress. However, I have changed my mind on the issue since you're right in that having the support doesn't really have any drawbacks. The downsides for not having it are poor SEO support and ugly URLs but the downside for having it are... well, nothing, really - but we need to have a way to fall back to hashbang URLs for people who need the older tech for support reasons. |
that's what Angular does anyway. You just do |
Conflicts: app/routes/articles.server.routes.js app/routes/core.server.routes.js config/express.js
Conflicts: app/tests/article.server.routes.test.js config/express.js
added in the new version |
Where it is merged? I can not see it neither on 0.4 branch nor master. |
I confirm, the routes were not merged. |
Is it merged? |
@rhutchison EDIT: This problem also happens without html5mode. :( |
@monad98 this PR is pretty out dated from upstream, so not sure how reliable it would be. I know @amoshaviv manually plucked these changes and put them in to the 0.4.0 branch (ab81d61#diff-90593c1684669b4a0cc185ec424f0a24R9) - have you had any luck there? |
Open for discussion. This pull request enables use of html5Mode. This should also still work with html5Mode(false).