This repository has been archived by the owner on Aug 30, 2021. It is now read-only.
Path to social meta brand image is wrong #321
Labels
Comments
|
@AndreasHassing this seems to have been fixed in the 0.4.0 branch. Can this be closed? |
|
Closing. It was another PR by @AndreasHassing that addressed this. |
pdfowler
pushed a commit
to pdfowler/mean
that referenced
this issue
Jan 19, 2016
…meanjs_0_4_0_merge * commit '709c27f9753ed09daf417d5f8d46ffd3293481f0': Wait for async saving and removing Change file ignore pattern to match word 'core' instead of chars Add missing newline at the end of text files Remove executable bit when not necessary Remove dist files 0.4.0 Adjust profile image URLs on Fb and Twitter strategies Auth service Remove username from facebook strategy Fix meanjs#321 image paths in social meta tags [v0.4] Fix meanjs#283 glob path issue for Windows Because html5Mode is enabled, the links the social buttons point to will not work, the request to /api/auth/{provider} will be captured by ui-router and directed back to /. Adding target="_self" to each link will fix this issue. Maybe creating a new directive for links to hit server side endpoints would be more appropriate but this should do for now. Conflicts: .gitignore Dockerfile config/assets/default.js modules/core/client/config/core.client.routes.js modules/core/client/controllers/home.client.controller.js modules/core/server/controllers/errors.server.controller.js modules/core/server/views/404.server.view.html modules/core/server/views/500.server.view.html modules/core/server/views/layout.server.view.html modules/users/client/controllers/authentication.client.controller.js modules/users/client/controllers/password.client.controller.js modules/users/client/services/authentication.client.service.js modules/users/client/services/users.client.service.js modules/users/client/views/authentication/authentication.client.view.html modules/users/server/config/strategies/local.js modules/users/server/controllers/users/users.authorization.server.controller.js modules/users/server/templates/reset-password-email.server.view.html public/dist/application.min.css public/dist/application.min.js
This was referenced Mar 25, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
In
app/views/layout.server.view.htmlthe path to the social media images in meta tags are wrong (img/brand/logo.png), should be:/modules/core/img/brand/logo.png.Already made a PR fixing this.
The text was updated successfully, but these errors were encountered: