Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Python version requirement, old references #35

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

schivmeister
Copy link
Contributor

This requires either a new release or recreation of release and PyPi distribution, as there is a possibility that dependency resolution may be affected.

This requires either a new release or recreation of release and PyPi
distribution, as there is a possibility that dependency resolution may
be affected.
The 0.3.0 release did not have an updated `python_requires` version
metadata and was "yanked" from PyPi.

See https://pypi.org/help/#yanked
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (52e91b7) 91.52% compared to head (eef21db) 91.52%.
Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #35   +/-   ##
=======================================
  Coverage   91.52%   91.52%           
=======================================
  Files           6        6           
  Lines          59       59           
=======================================
  Hits           54       54           
  Misses          5        5           
Flag Coverage Δ
unittests 91.52% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@schivmeister
Copy link
Contributor Author

schivmeister commented Feb 1, 2024

This was forgotten but finally decided to remove the release from GitHub and yank the package distribution from PyPi. A new release with a bumped version instead of the same version will be made to comply with the yanking and semantic versioning policy (although Pip supports resolving a post version specifier it would not be SemVer-compliant).

Users of PyPi (using Pip or otherwise) should get the following message upon a fresh or forced installation of this library:

WARNING: The candidate selected for download or install is a yanked version: 'rdf-fingerprinter' candidate (version 0.3.0 at https://files.pythonhosted.org/packages/7b/1d/beb285d87d9d48c676251c346972dc881ab9f427a98e100ecd742655c69e/rdf_fingerprinter-0.3.0-py3-none-any.whl (from https://pypi.org/simple/rdf-fingerprinter/) (requires-python:>=3.6))
Reason for being yanked: Python version metadata `python_requires` not updated from 3.6 to 3.8

Users who have already installed this and are installing other dependencies, or reinstalling this from cache, will not receive such a warning.

@schivmeister schivmeister merged commit 1c69612 into master Feb 1, 2024
5 checks passed
@schivmeister schivmeister deleted the feature/fix-version branch February 1, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants