feat: Change OpenAI Image Format to JPG #4117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monksy
approved these changes
Aug 29, 2024
|
File "/opt/pysetup/.venv/lib/python3.10/site-packages/PIL/JpegImagePlugin.py", line 642, in _save Happens when I use the crop feature on the example image provided #4097 |
|
Good catch, thanks! Newest commit fixes this |
boc-the-git
previously approved these changes
Aug 30, 2024
…om/michael-genson/mealie into feat/add-more-openai-compatability
boc-the-git
approved these changes
Aug 30, 2024
boc-the-git
pushed a commit
to boc-the-git/mealie
that referenced
this pull request
Sep 28, 2024
boc-the-git
pushed a commit
to boc-the-git/mealie
that referenced
this pull request
Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
(REQUIRED)
What this PR does / why we need it:
(REQUIRED)
Ollama only supports JPG and PNG formats, so the current implementation breaks since we use WEBP. JPG tends to have universal support, so I switched to that.
Which issue(s) this PR fixes:
(REQUIRED)
Fixes #4097