Generalize Reporting & Introduce suite-by-suite HTML Reporting #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
December 20, 2016 11:44
This is going to move out of terminate/2 and it's more clear this way.
We will need this if the HTML reporter is going to stick around long enough to recieve information about more than one BDD suite.
|
I'll resolve the failed builds on Travis: not sure why only some fail. |
|
Okay: the release notes for 1.2 write the following under enhancements.
|
Dzol
changed the title
Dzol
changed the title
This keeps the test and CI output like it was before we replaced the progress reporter with the event manager and generic servers.
Dzol
force-pushed
the
improve-report
branch
3 times, most recently
from
f7f82b8 to
335bffb
Compare
mentels
reviewed
Feb 2, 2017
lib/white_bread/event_manager.ex
Outdated
| for {_, pid, _, _} <- Supervisor.which_children(__MODULE__) do | ||
| GenServer.stop(pid, :normal, @timeout) | ||
| end | ||
| Supervisor.stop(__MODULE__) |
There was a problem hiding this comment.
As you're using Supervisor.stop/1 there's no need to individually stop the children. As they're linked they will be stopped along with the supervisor.
|
Bit late looking at this but I like the approach. Thanks for the contribution 👍 I'll merge and tag this morning. |
|
@meadsteve: Thanks for updating the README. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces and Event Manager similar to ExUnit's.
We can send test information to more than one outputter and keep the outputter processes spinning between test suites. This way the outputters, namely the
HTMLoutputter, can report on a suite-by-suite basis. TheConsoleoutputter is adapted (this PR makes it responsible for more of the console output we see).