Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make LinkedList iterator safe against removal of cur item #952

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make LinkedList iterator safe against removal of cur item #952

wants to merge 1 commit into from

Conversation

depau
Copy link

@depau depau commented Mar 7, 2021

This PR implements my suggested solution for #951.

Closes #951.

@depau depau mentioned this pull request Mar 10, 2021
Open
@sieren
Copy link

sieren commented May 24, 2021

This is great! Can we get this merged already or is this repo no longer maintained?
Seems like the issue described here happens a lot more often when compiling with current masters of ardiuno-esp32 and ESP-IDF 4.4 (Crashes on access, no matter what - verified fixed with this PR).

@zekageri zekageri mentioned this pull request May 25, 2021
Closed
@depau
Copy link
Author

depau commented May 31, 2021

FWIW I'm keeping a branch with all the bugfixes I need for my project here: https://github.com/Depau/ESPAsyncWebServer/tree/wi-se-patches

Feel free to use it until the fixes are merged.

@depau depau force-pushed the mem-corruption branch 2 times, most recently from 400ce4f to e9d32ba Compare August 1, 2021 09:27
@fcapano
Copy link

fcapano commented Aug 21, 2021

This issue has had me debugging memory corruption on an ESP32 until I came across this bug report.
The fix is working nicely for me. Too bad after more than 4 months it still hasn't been merged

@vortigont vortigont mentioned this pull request Jul 14, 2022
Open
jmysu added a commit to jmysu/ESP32C3_Pico that referenced this pull request Jul 21, 2022
@jmysu
Add websocket demo
08b4ff8 
there is a fix on ESP32C3 websocket StringArray crash:
me-no-dev/ESPAsyncWebServer#952
@teknoel
Copy link

teknoel commented Aug 23, 2022

is this fix related to this issue? #1201

@depau
Copy link
Author

depau commented Aug 24, 2022

is this fix related to this issue? #1201

Try the patches and see if it fixes your issues, I can't telepathically connect to your ESP32 to see it fixes the problem. https://github.com/Depau/ESPAsyncWebServer/tree/wi-se-patches

@depau
Copy link
Author

depau commented Aug 24, 2022

@teknoel since you mention websockets it might also be this other bug #953

This was referenced Sep 18, 2022
Open
Closed
Aircoookie added a commit to Aircoookie/ESPAsyncWebServer that referenced this pull request Sep 25, 2022
@Aircoookie
Patch for use-after-free (upstream PR me-no-dev#952)
6c40830
@Aircoookie Aircoookie mentioned this pull request Sep 25, 2022
Merged
Aircoookie added a commit to Aircoookie/ESPAsyncWebServer that referenced this pull request Sep 25, 2022
@Aircoookie
Patch for use-after-free (upstream PR me-no-dev#952) (#6)
ebbfed3
@barbiani barbiani mentioned this pull request Jan 5, 2023
Open
This was referenced Oct 15, 2023
Closed
Closed
nthd added a commit to nthd/ESPAsyncWebServer that referenced this pull request Oct 16, 2023
@nthd
Add PR Make LinkedList iterator safe against removal of cur item me-n…
8828f47 
…o-dev#952
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use-after-free in AsyncWebServerRequest::_removeNotInterestingHeaders
4 participants
@depau @sieren @fcapano @teknoel