Fix infinite loop if arg. protoypes don't match

Fixes valentjn/vscode-ltex#167.
me-johnomar · Nov 15, 2020 · 72590d4 · 72590d4
1 parent 7342942
commit 72590d4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/ltexls-core/src/main/java/org/bsplines/ltexls/parsing/latex/LatexAnnotatedTextBuilder.java b/ltexls-core/src/main/java/org/bsplines/ltexls/parsing/latex/LatexAnnotatedTextBuilder.java
@@ -690,7 +690,7 @@ public LatexAnnotatedTextBuilder addCode(String code) {
               for (LatexCommandSignature latexCommandSignature : possibleCommandSignatures) {
                 String curMatch = latexCommandSignature.matchFromPosition(code, this.pos);
 
-                if (curMatch.length() >= match.length()) {
+                if (!curMatch.isEmpty() && (curMatch.length() >= match.length())) {
                   match = curMatch;
                   matchingCommand = latexCommandSignature;
                 }

diff --git a/...s-core/src/test/java/org/bsplines/ltexls/parsing/latex/LatexAnnotatedTextBuilderTest.java b/...s-core/src/test/java/org/bsplines/ltexls/parsing/latex/LatexAnnotatedTextBuilderTest.java
@@ -144,6 +144,9 @@ public void testTextMode() {
         "This is a test: \\colorbox{abc}{def}.\n",
         "This is a test: Dummy0def. ",
         (new Settings()).withLatexCommands(Collections.singletonMap("\\colorbox{}", "dummy")));
+    assertPlainText(
+        "\\setcounter{a}[b]{c} This is an test.\n",
+        "a[b]c This is an test. ");
 
     {
       AnnotatedText annotatedText = buildAnnotatedText("\\cite{Kubota}*{Theorem 3.7}\n");