Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The guide at https://mdxjs.com/guides/math/ does not work #2341

Closed
4 tasks done
B1RO opened this issue Sep 2, 2023 · 1 comment · Fixed by #2360
Closed
4 tasks done

The guide at https://mdxjs.com/guides/math/ does not work #2341

B1RO opened this issue Sep 2, 2023 · 1 comment · Fixed by #2360
Labels
📚 area/docs This affects documentation 💪 phase/solved Post is done

Comments

@B1RO
Copy link

B1RO commented Sep 2, 2023 •
edited
Loading

Initial checklist

Affected packages and versions

.

Link to runnable example

No response

Steps to reproduce

Follow the guide in a mdx environment

Expected behavior

Math should be properly rendered

Actual behavior

The css file does not get loaded and math does not work. This is because the css file linked in the guide is obsolete/out of date. It'd be better if the part of the guide that explains the css part was modified.
I think you should remove the link to the css file, and link to katex page, so that user gets an up-to-date link. Every time I create a mdx project I forget this quirk with the docs and spend 20 minutes debugging the issues.

Runtime

No response

Package manager

No response

OS

No response

Build and bundle tools

No response
@wooorm
Copy link
Member

wooorm commented Sep 2, 2023

it’s open source! you can make a pr to help other folks!

@ChristianMurphy ChristianMurphy added good first issue 👋 This may be a great place to get started! 📚 area/docs This affects documentation labels Sep 22, 2023
@ChristianMurphy ChristianMurphy linked a pull request Oct 5, 2023 that will close this issue
Update link to KaTeX CSS in docs #2360
Merged
wooorm pushed a commit that referenced this issue Oct 10, 2023
@victor23k
Update link to KaTeX CSS in docs
07503a5 
Closes GH-2341.
Closes GH-2360.

Reviewed-by: Titus Wormer <tituswormer@gmail.com>
@wooorm wooorm added 💪 phase/solved Post is done and removed good first issue 👋 This may be a great place to get started! labels Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
📚 area/docs This affects documentation 💪 phase/solved Post is done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update link to KaTeX CSS in docs victor23k/mdx
3 participants
@wooorm @ChristianMurphy @B1RO