use dep

mdx-js · Apr 23, 2022 · 9506240 · 9506240
1 parent d24a339
commit 9506240
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 29 deletions.
diff --git a/packages/mdx/lib/plugin/recma-document.js b/packages/mdx/lib/plugin/recma-document.js
@@ -43,7 +43,7 @@
 import {analyze} from 'periscopic'
 import {stringifyPosition} from 'unist-util-stringify-position'
 import {positionFromEstree} from 'unist-util-position-from-estree'
-import {visit, SKIP} from 'estree-util-visit'
+import {walk} from 'estree-walker'
 import {create} from '../util/estree-util-create.js'
 import {specifiersToDeclarations} from '../util/estree-util-specifiers-to-declarations.js'
 import {declarationToExpression} from '../util/estree-util-declaration-to-expression.js'
@@ -299,36 +299,23 @@ export function recmaDocument(options = {}) {
     tree.body = replacement
 
     if (baseUrl) {
-      visit(tree, (node, field, index, parents) => {
-        if (
-          node.type === 'MemberExpression' &&
-          'object' in node &&
-          node.object.type === 'MetaProperty' &&
-          node.property.type === 'Identifier' &&
-          node.object.meta.name === 'import' &&
-          node.object.property.name === 'meta' &&
-          node.property.name === 'url'
-        ) {
-          /** @type {string|number|null} */
-          let prop = field
-          let context = /** @type {Node|Array<Node>} */ (
-            parents[parents.length - 1]
-          )
-
-          // Remove non-standard `ParenthesizedExpression`.
-          if (context && prop) {
-            /* c8 ignore next 5 */
-            if (typeof index === 'number') {
-              // @ts-expect-error: indexable.
-              context = context[prop]
-              prop = index
-            }
+      walk(tree, {
+        enter(_node) {
+          const node = /** @type {Node} */ (_node)
 
-            // @ts-expect-error: indexable.
-            context[prop] = {type: 'Literal', value: baseUrl}
+          if (
+            node.type === 'MemberExpression' &&
+            'object' in node &&
+            node.object.type === 'MetaProperty' &&
+            node.property.type === 'Identifier' &&
+            node.object.meta.name === 'import' &&
+            node.object.property.name === 'meta' &&
+            node.property.name === 'url'
+          ) {
+            /** @type {SimpleLiteral} */
+            const replacement = {type: 'Literal', value: baseUrl}
+            this.replace(replacement)
           }
-
-          return SKIP
         }
       })
     }

diff --git a/packages/mdx/test/compile.js b/packages/mdx/test/compile.js
@@ -536,6 +536,7 @@ test('compile', async () => {
     )
   }
 
+  console.log('\nnote: the following warning is expected!\n')
   assert.equal(
     renderToStaticMarkup(
       React.createElement(
@@ -545,6 +546,7 @@ test('compile', async () => {
     '<a></a>',
     'should render if a used member is defined locally (JSX in a function)'
   )
+  console.log('\nnote: the preceding warning is expected!\n')
 
   try {
     renderToStaticMarkup(