-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[POC] Start support typescript #196
Conversation
very cool |
@Kingwl Great thanks! I previously noticed unified-language-server created by @remcohaszing, is there any chance to reuse it here? Never mind if you think not or unnecessary. |
Awesome! @JounQin Thanks for pinging me! I have been thinking of working in this myself, but haven’t gotten to it yet.
I need to provide this functionality My idea is to create the following projects:
This setup is also how for example TypeScript, JavaScript, JSON, CSS, and YAML support are added into both Monaco editor and VS Code. Such clear distinctions also add to testability. A language service is fairly easy to test, as it just exposes JavaScript functions. Its test case can be extensive (100% coverage). A language server is a bit more annoying to test, but it’s doable. The language server test case doesn’t need to be as extensive as the language service tests. Tests for both Monaco editor and the VS Code extension can be minimal. |
Fixed #165
About the PR
It's just a proto for typescript support.
As you can see, there's tons of bugs and many features need to implement or improve.
However, It's might be the first step of better support.
About the code
PS: plugin is basically copies from @orta 's svelte plugin. And All the implement is inspired by @orta too.
Preview