Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request completionItem/resolve failed error #301

Closed
4 tasks done
johno opened this issue Feb 19, 2023 · 2 comments · Fixed by #340
Closed
4 tasks done

Request completionItem/resolve failed error #301

johno opened this issue Feb 19, 2023 · 2 comments · Fixed by #340
Labels
💪 phase/solved Post is done 🐛 type/bug This is a problem

Comments

@johno
Copy link
Member

johno commented Feb 19, 2023 •
edited
Loading

Initial checklist

Affected packages and versions

Latest (1.2.2)

Link to runnable example

No response

Steps to reproduce

It seems to happen intermittently, and haven't fully figured out why/where it occurs. Here's an example of an MDX document that reproduces the error:

# Example document

- [Link](/a)
- [Link](/a)
- [Link](/a)

## Below 

Typing here causes the error CURSOR LOCATION

- [Link](/a)

Expected behavior

Doesn't error, or at the very least does so silently.

Actual behavior

It errors, and once it gets going, does so repeatedly.

Screenshot

image

Logs

[Error - 3:09:56 PM] Request completionItem/resolve failed.
  Message: Request completionItem/resolve failed with message: Cannot read properties of undefined (reading 'kind')
  Code: -32603 
[Error - 3:11:48 PM] Request completionItem/resolve failed.
  Message: Request completionItem/resolve failed with message: Cannot read properties of undefined (reading 'kind')
  Code: -32603 
[Error - 3:12:16 PM] Request completionItem/resolve failed.
  Message: Request completionItem/resolve failed with message: Cannot read properties of undefined (reading 'kind')
  Code: -32603 
[Error - 3:12:28 PM] Request completionItem/resolve failed.
  Message: Request completionItem/resolve failed with message: Cannot read properties of undefined (reading 'kind')
  Code: -32603 
[Error - 3:12:32 PM] Request completionItem/resolve failed.
  Message: Request completionItem/resolve failed with message: Cannot read properties of undefined (reading 'kind')
  Code: -32603 
[Error - 3:14:39 PM] Request completionItem/resolve failed.
  Message: Request completionItem/resolve failed with message: Cannot read properties of undefined (reading 'kind')
  Code: -32603 
[Error - 3:20:22 PM] Request completionItem/resolve failed.
  Message: Request completionItem/resolve failed with message: Cannot read properties of undefined (reading 'kind')
  Code: -32603 
[Error - 3:44:56 PM] Request completionItem/resolve failed.
  Message: Request completionItem/resolve failed with message: Cannot read properties of undefined (reading 'kind')
  Code: -32603

Runtime

Node v18

Package manager

yarn v1

OS

macOS

Build and bundle tools

webpack, Next.js

Thank you for your work on this project, it's great! 🙏 🙏 💟
@johno johno added 🐛 type/bug This is a problem 🤞 phase/open Post is being triaged manually labels Feb 19, 2023
@remcohaszing
Copy link
Member

remcohaszing commented Feb 20, 2023 •
edited
Loading

I tried it. It’s doesn’t happen after every keystroke, but I am able to reproduce this bug.

Thanks for reporting!

Thank you for your work on this project, it's great! 🙏 🙏 💟

❤️

@remcohaszing remcohaszing added 🙆 yes/confirmed This is confirmed and ready to be worked on 👍 phase/yes Post is accepted and can be worked on and removed 🤞 phase/open Post is being triaged manually labels Feb 20, 2023
remcohaszing added a commit that referenced this issue Aug 18, 2023
@remcohaszing
Integrate Volar
e236368 
- Volar handles the mapping between TypeScript and LSP.
- Volar handles the mapping between TypeScript and Monaco editor.
- Volar manages virtual files.
- Volar imports TypeScript directly. As a result, the Monaco editor
  integration now requires `path` to be polyfilled.
- It is no longer possible to pass compiler options in the Monaco editor
  integration.
- This adds editor features for YAML based on `yaml-language-server`.
  This has been contributed upstream to Volar and is pending review.
- Markdown features are now handled by
  `vscode-markdown-languageservice`. This will be contributed upstream
  to Volar soon.
- Markdown definitions are broken due to a bug in Volar.
- This adds `remark-frontmatter` with TOML and YAML support as well as
  `remark-gfm` by default unless specified otherwise in `tsconfig.json`.
- The language server now requires `typescript.tsdk` to be passed via
  initialization options.
- This adds support for debugging virtual documents using Volar labs.

Closes #168
Closes #284
Closes #295
Closes #298
Closes #301
@remcohaszing remcohaszing mentioned this issue Aug 18, 2023
Merged
@remcohaszing
Copy link
Member

Released in vscode-mdx@1.5.0, @mdx-js/language-server@0.2.0 🎉

@wooorm wooorm added the 💪 phase/solved Post is done label Nov 9, 2023
@github-actions github-actions bot removed 👍 phase/yes Post is accepted and can be worked on 🙆 yes/confirmed This is confirmed and ready to be worked on labels Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💪 phase/solved Post is done 🐛 type/bug This is a problem
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Integrate Volar mdx-js/mdx-analyzer
3 participants
@remcohaszing @wooorm @johno