Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preset-prettier integration broken after update of remark-preset-prettier to 2.0.0 #427

Closed
4 tasks done
enqueue opened this issue Sep 12, 2022 · 4 comments · Fixed by un-ts/remark-preset-prettier#105 or #428
Closed
4 tasks done

Comments

@enqueue
Copy link

enqueue commented Sep 12, 2022

Initial checklist

Affected packages and versions

eslint-plugin-mdx 2.0.4

Link to runnable example

Not runnable, but easily made runnable: https://github.com/enqueue/eslint-mdx-reproducer

Steps to reproduce

  1. Set up a project with eslint-plugin-mdx and remark-preset-prettier version 2.0.0
  2. Add "preset-prettier" plugin to projects remarkrc
  3. Run eslint .

(Hopefully) minimal reproducible example over here: https://github.com/enqueue/eslint-mdx-reproducer

Node version is 18.9

Expected behavior

MDX and MD files are linted according to rules.

Actual behavior

Error message 0:0 error Parsing error: Cannot find module 'preset-prettier'.

Runtime

Other (please specify in steps to reproduce)

Package manager

npm v8

OS

Linux

Build and bundle tools

No response

Workaround

My current workaround is to pin the dependency of remark-preset-prettier to 1.0.2

@enqueue enqueue changed the title preset-prettier integration broken after update to 2.0.0 preset-prettier integration broken after update of remark-preset-prettier to 2.0.0 Sep 12, 2022
@JounQin
Copy link
Member

JounQin commented Sep 12, 2022

Thanks for reproduction, I'll check soon.

@JounQin
Copy link
Member

JounQin commented Sep 12, 2022

@enqueue Please use remark-preset-prettier@2.0.1 before next version of eslint-mdx. They fix this issue with different ways.

@enqueue
Copy link
Author

enqueue commented Sep 12, 2022

@JounQin thanks for the super-fast fix. I wasn't sure in which project this bug report belonged.

@JounQin
Copy link
Member

JounQin commented Sep 12, 2022

I maintain both eslint-mdx and remark-preset-prettier at the same time.

I wasn't sure in which project this bug report belonged.

It is indeed an issue at eslint-mdx's side, but there could be a workaround from remark-preset-prettier, and that makes itself more compatible.

JounQin added a commit that referenced this issue Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants