Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] add support for linting code blocks #278

Closed
JounQin opened this issue Mar 2, 2021 · 3 comments
Closed

[feature] add support for linting code blocks #278

JounQin opened this issue Mar 2, 2021 · 3 comments
Labels
💪 phase/solved Post is done 🦋 type/enhancement This is great to have

Comments

@JounQin
Copy link
Member

JounQin commented Mar 2, 2021

We can already get code blocks in eslint-mdx, so it should be possible to lint them by eslint-plugin-mdx itself.

A setting named lintCodeBlocks: boolean should be required.

Additional, we can reference eslint-plugin-markdown's codes.

@JounQin
Copy link
Member Author

JounQin commented Mar 16, 2021

@chenxsan Please try v1.10.0 with settings "mdx/code-blocks": true, "processor": "mdx/remark" is configed automatically, don't use "processor": "markdown/markdown".

@chenxsan
Copy link
Contributor

@JounQin Thanks for your work, I'll test it soon.

@JounQin
Copy link
Member Author

JounQin commented Mar 17, 2021

Due to an unreleased bugfix #285, you need to provide a remark config temporarily.

@wooorm wooorm added ⛵️ status/released and removed 🙉 open/needs-info This needs some more info labels Apr 12, 2021
@wooorm wooorm added the 💪 phase/solved Post is done label Dec 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 phase/solved Post is done 🦋 type/enhancement This is great to have
Development

Successfully merging a pull request may close this issue.

3 participants