Skip to content

Commit

Permalink
Deprecate CompositeReactPackage (facebook#39565)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: facebook#39565

CompositeReactPackage is not used at Meta neither in github public repositories, we are deprecating it in v0.73 with the goal to remove it in v0.74

changelog: [Android][Breaking] Deprecate CompositeReactPackage from RN Android

Reviewed By: christophpurrer

Differential Revision: D49440130

fbshipit-source-id: 568a7295ca9422603ac218b3610bfdbff574052b
  • Loading branch information
mdvacca committed Sep 21, 2023
1 parent e2b4f36 commit f43c414
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,12 @@
/**
* {@code CompositeReactPackage} allows to create a single package composed of views and modules
* from several other packages.
*
* @deprecated
*/
@Deprecated(
since = "CompositeReactPackage sis deprecated and will be deleted, Use ReactPackage instead",
forRemoval = true)
public class CompositeReactPackage implements ViewManagerOnDemandReactPackage, ReactPackage {

private final List<ReactPackage> mChildReactPackages = new ArrayList<>();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -95,11 +95,8 @@ public void remove() {
protected abstract List<ModuleSpec> getNativeModules(ReactApplicationContext reactContext);

/**
* This is only used when a LazyReactPackage is a part of {@link CompositeReactPackage} Once we
* deprecate {@link CompositeReactPackage}, this can be removed too
*
* @param reactContext react application context that can be used to create modules
* @return
* @return {@link List<NativeModule>} to register
*/
@Override
public final List<NativeModule> createNativeModules(ReactApplicationContext reactContext) {
Expand Down

0 comments on commit f43c414

Please sign in to comment.